tools/testing/dart/test_runner.dart - Issue 610863004: Start implementing checked mode compile time errors in analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 610863004: Start implementing checked mode compile time errors in analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes based on review comments and in-person discussion Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index 35d6613b154389d847b91fcf68d146a702f284d7..b88381e0c4fb5d9295eecfa006531e6aef9a5efd 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -1441,9 +1441,7 @@ class AnalysisCommandOutputImpl extends CommandOutputImpl {

parseAnalyzerOutput(errors, warnings);

// Handle errors / missing errors

- if (testCase.hasCompileError) {

- // Don't use [TestCase.expectCompileError] since the analyzer does not

- // (currently) report checked-mode only compile time errors.

+ if (testCase.expectCompileError) {

if (errors.length > 0) {

return Expectation.PASS;

}

« no previous file with comments | « tests/language/language_analyzer2.status ('k') | no next file » | no next file with comments »