Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 610863004: Start implementing checked mode compile time errors in analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes based on review comments and in-person discussion Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/language/language_analyzer2.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1423 matching lines...) Expand 10 before | Expand all | Expand 10 after
1434 // Handle crashes and timeouts first 1434 // Handle crashes and timeouts first
1435 if (hasCrashed) return Expectation.CRASH; 1435 if (hasCrashed) return Expectation.CRASH;
1436 if (hasTimedOut) return Expectation.TIMEOUT; 1436 if (hasTimedOut) return Expectation.TIMEOUT;
1437 1437
1438 // Get the errors/warnings from the analyzer 1438 // Get the errors/warnings from the analyzer
1439 List<String> errors = []; 1439 List<String> errors = [];
1440 List<String> warnings = []; 1440 List<String> warnings = [];
1441 parseAnalyzerOutput(errors, warnings); 1441 parseAnalyzerOutput(errors, warnings);
1442 1442
1443 // Handle errors / missing errors 1443 // Handle errors / missing errors
1444 if (testCase.hasCompileError) { 1444 if (testCase.expectCompileError) {
1445 // Don't use [TestCase.expectCompileError] since the analyzer does not
1446 // (currently) report checked-mode only compile time errors.
1447 if (errors.length > 0) { 1445 if (errors.length > 0) {
1448 return Expectation.PASS; 1446 return Expectation.PASS;
1449 } 1447 }
1450 return Expectation.MISSING_COMPILETIME_ERROR; 1448 return Expectation.MISSING_COMPILETIME_ERROR;
1451 } 1449 }
1452 if (errors.length > 0) { 1450 if (errors.length > 0) {
1453 return Expectation.COMPILETIME_ERROR; 1451 return Expectation.COMPILETIME_ERROR;
1454 } 1452 }
1455 1453
1456 // Handle static warnings / missing static warnings 1454 // Handle static warnings / missing static warnings
(...skipping 1496 matching lines...) Expand 10 before | Expand all | Expand 10 after
2953 } 2951 }
2954 } 2952 }
2955 2953
2956 void eventAllTestsDone() { 2954 void eventAllTestsDone() {
2957 for (var listener in _eventListener) { 2955 for (var listener in _eventListener) {
2958 listener.allDone(); 2956 listener.allDone();
2959 } 2957 }
2960 _allDone(); 2958 _allDone();
2961 } 2959 }
2962 } 2960 }
OLDNEW
« no previous file with comments | « tests/language/language_analyzer2.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698