Issue 598883002: Fix an error-swallowing bug in pub and several bugs it was hiding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 598883002: Fix an error-swallowing bug in pub and several bugs it was hiding. (Closed)

Created:
6 years, 3 months ago by nweiz

Modified:
6 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix an error-swallowing bug in pub and several bugs it was hiding. We were passing an error to [completer.completer] rather than [completer.completeError] and this was hiding several behavioral bugs. R=rnystrom@google.com TBR Committed: https://code.google.com/p/dart/source/detail?r=40621

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -49 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart	View	3 chunks	+2 lines, -26 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/package_graph.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart	View	3 chunks	+2 lines, -18 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/package_graph.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 (id:1) manually as 40621 (presubmit successful).

6 years, 3 months ago (2014-09-24 01:40:36 UTC) #2

Bob Nystrom

6 years, 3 months ago (2014-09-24 17:19:38 UTC) #3

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/598883002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/package_graph.dart (right):

https://codereview.chromium.org/598883002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/package_graph.dart:112: if (source is!
CachedSource) return false;
I didn't do a good code review job. :(

Expand Messages | Collapse Messages