sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart - Issue 598883002: Fix an error-swallowing bug in pub and several bugs it was hiding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart

Issue 598883002: Fix an error-swallowing bug in pub and several bugs it was hiding. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/pub/lib/src/package_graph.dart ('K') | « sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart ('k') | sdk/lib/_internal/pub_generated/lib/src/package_graph.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart

diff --git a/sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart b/sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart

index 4ac4dae1531538b7059cb321ab7b11b97c1c9d98..4f760357a362d832588b90907601aa10e4f3c4d8 100644

--- a/sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart

+++ b/sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart

@@ -47,9 +47,16 @@ Future loadAllTransformers(AssetEnvironment environment,

var transformers =

environment.getBuiltInTransformers(package);

join0() {

- newFuture(

- (() => environment.barback.updateTransformers(package.name, phases)));

- completer0.complete(null);

+ join1() {

+ newFuture(

+ (() => environment.barback.updateTransformers(package.name, phases)));

+ completer0.complete(null);

+ }

+ if (phases.isEmpty) {

+ completer0.complete(null);

+ } else {

+ join1();

+ }

}

if (transformers != null) {

phases.add(transformers);