Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: sdk/lib/_internal/pub/lib/src/package_graph.dart

Issue 598883002: Fix an error-swallowing bug in pub and several bugs it was hiding. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/package_graph.dart
diff --git a/sdk/lib/_internal/pub/lib/src/package_graph.dart b/sdk/lib/_internal/pub/lib/src/package_graph.dart
index a66872bb1474486797092fb24c9ef9358cf2f2ce..02ba973bd1b4deeb6f51b06b6ce44b139c07b8bb 100644
--- a/sdk/lib/_internal/pub/lib/src/package_graph.dart
+++ b/sdk/lib/_internal/pub/lib/src/package_graph.dart
@@ -109,7 +109,7 @@ class PackageGraph {
if (id == null) return false;
var source = entrypoint.cache.sources[id.source];
- if (source is! CachedSource) return true;
+ if (source is! CachedSource) return false;
Bob Nystrom 2014/09/24 17:19:37 I didn't do a good code review job. :(
return packages[package].pubspec.transformers.isEmpty;
}

Powered by Google App Engine
This is Rietveld 408576698