sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart - Issue 598883002: Fix an error-swallowing bug in pub and several bugs it was hiding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

Issue 598883002: Fix an error-swallowing bug in pub and several bugs it was hiding. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart ('k') | sdk/lib/_internal/pub/lib/src/package_graph.dart » ('j') | sdk/lib/_internal/pub/lib/src/package_graph.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart b/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

index cb4a64425bb0cde213fb527a76101f7d9db9eaa0..b23eb14dd20543022a56a113ae13b38e813ada6b 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

@@ -83,6 +83,7 @@ Future loadAllTransformers(AssetEnvironment environment,

package.pubspec.transformers);

var transformers = environment.getBuiltInTransformers(package);

if (transformers != null) phases.add(transformers);

+ if (phases.isEmpty) return;

// TODO(nweiz): remove the [newFuture] here when issue 17305 is fixed.

// If no transformer in [phases] applies to a source input,