Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 514833003: Add a new Sentinel type for sentinel responses. (They are not Null). (Closed)

Created:
6 years, 3 months ago by turnidge
Modified:
6 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Add a new Sentinel type for sentinel responses. (They are not Null). Fix some stray problems. Silence warnings about stray GC events. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=39663

Patch Set 1 #

Patch Set 2 : gen js, fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -51 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/app/application.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.html View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/service.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M runtime/vm/service/protocol.md View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/service_test.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/vmservice/isolate_bad_object_test.dart View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
turnidge@google.com changed reviewers: + rmacnak@google.com
6 years, 3 months ago (2014-08-27 20:43:25 UTC) #1
turnidge
6 years, 3 months ago (2014-08-27 20:43:26 UTC) #2
rmacnak
lgtm
6 years, 3 months ago (2014-08-27 21:19:11 UTC) #3
turnidge
6 years, 3 months ago (2014-08-28 16:52:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 39663 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698