runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html - Issue 514833003: Add a new Sentinel type for sentinel responses. (They are not Null).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html

Issue 514833003: Add a new Sentinel type for sentinel responses. (They are not Null). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js, fix tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html ('k') | runtime/bin/vmservice/observatory/lib/src/app/application.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html

diff --git a/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html b/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html

index 1d7166c0f3d74764ec0ca0e43761295f863bb5f7..7bdaef3ce83ff93a8ac1345a8635fa594f8d7ff3 100644

--- a/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html

+++ b/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html

@@ -30,11 +30,11 @@

- <template if="{{ isType(instance.serviceType) }}">

- <h1>type {{ instance['user_name'] }}</h1>

+ <template if="{{ isType(instance) }}">

+ <h1>type {{ instance.name }}</h1>

</template>

- <template if="{{ !isType(instance.serviceType) }}">

- <h1>instance of {{ instance['class']['user_name'] }}</h1>

+ <template if="{{ !isType(instance) }}">

+ <h1>instance of {{ instance['class'].name }}</h1>

</template>

@@ -213,4 +213,4 @@

</template>

</polymer-element>

-<script type="application/dart" src="instance_view.dart"></script>

+<script type="application/dart" src="instance_view.dart"></script>