Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: tests/standalone/vmservice/isolate_bad_object_test.dart

Issue 514833003: Add a new Sentinel type for sentinel responses. (They are not Null). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js, fix tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/vmservice/isolate_bad_object_test.dart
diff --git a/tests/standalone/vmservice/isolate_bad_object_test.dart b/tests/standalone/vmservice/isolate_bad_object_test.dart
index 8addb4c14b007a370033ba50aa152fcda7e566f1..3b399daccc68249ad27a8660ae0354b6ea0c3423 100644
--- a/tests/standalone/vmservice/isolate_bad_object_test.dart
+++ b/tests/standalone/vmservice/isolate_bad_object_test.dart
@@ -8,12 +8,13 @@ import 'dart:async';
import 'test_helper.dart';
import 'package:expect/expect.dart';
-class NullCollectionTest extends VmServiceRequestHelper {
- NullCollectionTest(port, id) :
+class ExpiredCollectionTest extends VmServiceRequestHelper {
+ ExpiredCollectionTest(port, id) :
super('http://127.0.0.1:$port/$id/objects/50');
onRequestCompleted(Map reply) {
- Expect.equals('Null', reply['type']);
+ Expect.equals('Sentinel', reply['type']);
+ Expect.equals('<expired>', reply['valueAsString']);
}
}
@@ -44,9 +45,10 @@ main() {
test.makeRequest().then((_) {
var badCollectionRequest =
new BadCollectionTest(port, test._isolateId).makeRequest();
- var nullCollectionRequest =
- new NullCollectionTest(port, test._isolateId).makeRequest();
- var requests = Future.wait([badCollectionRequest, nullCollectionRequest]);
+ var expiredCollectionRequest =
+ new ExpiredCollectionTest(port, test._isolateId).makeRequest();
+ var requests = Future.wait([badCollectionRequest,
+ expiredCollectionRequest]);
requests.then((_) {
process.requestExit();
});
« no previous file with comments | « runtime/vm/service_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698