runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html - Issue 514833003: Add a new Sentinel type for sentinel responses. (They are not Null).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html

Issue 514833003: Add a new Sentinel type for sentinel responses. (They are not Null). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js, fix tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/deployed/web/index_devtools.html ('k') | runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html

diff --git a/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html b/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html

index be0893ce00f33c6b38bb550e59581f7fc67a63d4..7b7f43a6ca76e8d31bb335c3ab8500acaf290b18 100644

--- a/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html

+++ b/runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html

@@ -26,7 +26,7 @@

unexpected reference type <{{ ref.serviceType }}>

</template>

- <template if="{{ isPsuedoNull(ref) }}">

+ <template if="{{ isSentinel(ref) }}">

<div title="{{ hoverText }}">{{ ref['valueAsString'] }}</div>

</template>