Mix in [TreeElementMixin] only on nodes that need it.

Mix in [TreeElementMixin] only on nodes that need it.

BUG=http://dartbug.com/16002
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38847

[Johnni Winther, 2014-07-25 10:22:20]

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart
(left):

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart:243:
// definitionElement == null if variable is actually unused.
Not true.

https://codereview.chromium.org/422483002/diff/1/tests/compiler/dart2js/resol...
File tests/compiler/dart2js/resolver_test.dart (right):

https://codereview.chromium.org/422483002/diff/1/tests/compiler/dart2js/resol...
tests/compiler/dart2js/resolver_test.dart:418: Expect.equals(9,
map(visitor).length);
We don't store the element for the type anymore.

https://codereview.chromium.org/422483002/diff/1/tests/compiler/dart2js/resol...
tests/compiler/dart2js/resolver_test.dart:612: Expect.equals(1, mapping.length);
We don't store the element for the type and the element for the function
declaration anymore.

https://codereview.chromium.org/422483002/diff/1/tests/compiler/dart2js/unpar...
File tests/compiler/dart2js/unparser_test.dart (right):

https://codereview.chromium.org/422483002/diff/1/tests/compiler/dart2js/unpar...
tests/compiler/dart2js/unparser_test.dart:219:
testUnparseMemberAndAsMemberOfFoo("factory Foo()=Bar;");
Minified unparsing is tested. The unparser has been optimized for this for
RedirectingFactoryBody nodes.

[floitsch, 2014-07-25 12:30:09]

LGTM.

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/closure.dart (left):

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/closure.dart:1003:
visitFunctionDeclaration(FunctionDeclaration node) {
We need to declare the local in the current scope in case the declaration is
captured.

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2428:
inFunctionDeclaration = true;
Add comment explaining that the boolean is reset inside the
visitFunctionExpression.

Alternatively call visitFunctionExpression directly (instead of through "visit")
and pass in an optional boolean argument. I think I would prefer that.

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/resolution/secret_tree_element.dart
(right):

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/secret_tree_element.dart:27:
abstract class TreeElementMixin implements Spannable {
Let's go for an interface and two implementations: Null, and Stored.

[Johnni Winther, 2014-08-04 06:59:09]

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/closure.dart (left):

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/closure.dart:1003:
visitFunctionDeclaration(FunctionDeclaration node) {
On 2014/07/25 12:30:08, floitsch wrote:
> We need to declare the local in the current scope in case the declaration is
> captured.

Reinserting though we don't need it. Fixing this issue in a later CL.

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2428:
inFunctionDeclaration = true;
On 2014/07/25 12:30:08, floitsch wrote:
> Add comment explaining that the boolean is reset inside the
> visitFunctionExpression.
> 
> Alternatively call visitFunctionExpression directly (instead of through
"visit")
> and pass in an optional boolean argument. I think I would prefer that.

Done.

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
File
sdk/lib/_internal/compiler/implementation/resolution/secret_tree_element.dart
(right):

https://codereview.chromium.org/422483002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/resolution/secret_tree_element.dart:27:
abstract class TreeElementMixin implements Spannable {
On 2014/07/25 12:30:08, floitsch wrote:
> Let's go for an interface and two implementations: Null, and Stored.

Done.

[Johnni Winther, 2014-08-04 07:51:21]

Committed patchset #3 manually as r38847 (presubmit successful).