Mix in [TreeElementMixin] only on nodes that need it.

tests/compiler/dart2js/unparser_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import 'parser_helper.dart';
 import 'mock_compiler.dart';
 import 'package:compiler/implementation/tree/tree.dart';
 
 testUnparse(String statement) {
@@ skipping 198 matching lines @@
   testUnparseTopLevelWithMetadata('import "lib.dart" deferred as a show b;');
   testUnparseTopLevelWithMetadata('import "lib.dart" deferred as a hide b;');
 }
 
 testUnparseMemberAndAsMemberOfFoo(String code) {
   testUnparseMember(code);
   testUnparseTopLevelWithMetadata('class Foo{$code}');
 }
 
 testRedirectingFactoryConstructors() {
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = Bar;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = Bar.baz;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = Bar<T>;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = Bar<List<T>,T>;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = Bar<T>.baz;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = Bar<List<T>,T>.baz;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = prefix.Bar;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = prefix.Bar.baz;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = prefix.Bar<T>;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = prefix.Bar<List<T>,T>;");
-  testUnparseMemberAndAsMemberOfFoo("factory Foo() = prefix.Bar<T>.baz;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=Bar;");

[Johnni Winther, 2014/07/25 10:22:20]

Minified unparsing is tested. The unparser has been optimized for this for
RedirectingFactoryBody nodes.

+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=Bar.baz;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=Bar<T>;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=Bar<List<T>,T>;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=Bar<T>.baz;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=Bar<List<T>,T>.baz;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=prefix.Bar;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=prefix.Bar.baz;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=prefix.Bar<T>;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=prefix.Bar<List<T>,T>;");
+  testUnparseMemberAndAsMemberOfFoo("factory Foo()=prefix.Bar<T>.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "factory Foo() = prefix.Bar<List<T>,T>.baz;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = Bar;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = Bar.baz;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = Bar<T>;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = Bar<List<T>,T>;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = Bar<T>.baz;");
+      "factory Foo()=prefix.Bar<List<T>,T>.baz;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=Bar;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=Bar.baz;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=Bar<T>;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=Bar<List<T>,T>;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=Bar<T>.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "const factory Foo() = Bar<List<T>,T>.baz;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = prefix.Bar;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = prefix.Bar.baz;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = prefix.Bar<T>;");
+      "const factory Foo()=Bar<List<T>,T>.baz;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=prefix.Bar;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=prefix.Bar.baz;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=prefix.Bar<T>;");
   testUnparseMemberAndAsMemberOfFoo(
-      "const factory Foo() = prefix.Bar<List<T>,T>;");
-  testUnparseMemberAndAsMemberOfFoo("const factory Foo() = prefix.Bar<T>.baz;");
+      "const factory Foo()=prefix.Bar<List<T>,T>;");
+  testUnparseMemberAndAsMemberOfFoo("const factory Foo()=prefix.Bar<T>.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "const factory Foo() = prefix.Bar<List<T>,T>.baz;");
-  testUnparseMemberAndAsMemberOfFoo("external factory Foo() = Bar;");
-  testUnparseMemberAndAsMemberOfFoo("external factory Foo() = Bar.baz;");
-  testUnparseMemberAndAsMemberOfFoo("external factory Foo() = Bar<T>;");
-  testUnparseMemberAndAsMemberOfFoo("external factory Foo() = Bar<List<T>,T>;");
-  testUnparseMemberAndAsMemberOfFoo("external factory Foo() = Bar<T>.baz;");
+      "const factory Foo()=prefix.Bar<List<T>,T>.baz;");
+  testUnparseMemberAndAsMemberOfFoo("external factory Foo()=Bar;");
+  testUnparseMemberAndAsMemberOfFoo("external factory Foo()=Bar.baz;");
+  testUnparseMemberAndAsMemberOfFoo("external factory Foo()=Bar<T>;");
+  testUnparseMemberAndAsMemberOfFoo("external factory Foo()=Bar<List<T>,T>;");
+  testUnparseMemberAndAsMemberOfFoo("external factory Foo()=Bar<T>.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external factory Foo() = Bar<List<T>,T>.baz;");
-  testUnparseMemberAndAsMemberOfFoo("external factory Foo() = prefix.Bar;");
-  testUnparseMemberAndAsMemberOfFoo("external factory Foo() = prefix.Bar.baz;");
-  testUnparseMemberAndAsMemberOfFoo("external factory Foo() = prefix.Bar<T>;");
+      "external factory Foo()=Bar<List<T>,T>.baz;");
+  testUnparseMemberAndAsMemberOfFoo("external factory Foo()=prefix.Bar;");
+  testUnparseMemberAndAsMemberOfFoo("external factory Foo()=prefix.Bar.baz;");
+  testUnparseMemberAndAsMemberOfFoo("external factory Foo()=prefix.Bar<T>;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external factory Foo() = prefix.Bar<List<T>,T>;");
+      "external factory Foo()=prefix.Bar<List<T>,T>;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external factory Foo() = prefix.Bar<T>.baz;");
+      "external factory Foo()=prefix.Bar<T>.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external factory Foo() = prefix.Bar<List<T>,T>.baz;");
-  testUnparseMemberAndAsMemberOfFoo("external const factory Foo() = Bar;");
-  testUnparseMemberAndAsMemberOfFoo("external const factory Foo() = Bar.baz;");
-  testUnparseMemberAndAsMemberOfFoo("external const factory Foo() = Bar<T>;");
+      "external factory Foo()=prefix.Bar<List<T>,T>.baz;");
+  testUnparseMemberAndAsMemberOfFoo("external const factory Foo()=Bar;");
+  testUnparseMemberAndAsMemberOfFoo("external const factory Foo()=Bar.baz;");
+  testUnparseMemberAndAsMemberOfFoo("external const factory Foo()=Bar<T>;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = Bar<List<T>,T>;");
+      "external const factory Foo()=Bar<List<T>,T>;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = Bar<T>.baz;");
+      "external const factory Foo()=Bar<T>.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = Bar<List<T>,T>.baz;");
+      "external const factory Foo()=Bar<List<T>,T>.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = prefix.Bar;");
+      "external const factory Foo()=prefix.Bar;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = prefix.Bar.baz;");
+      "external const factory Foo()=prefix.Bar.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = prefix.Bar<T>;");
+      "external const factory Foo()=prefix.Bar<T>;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = prefix.Bar<List<T>,T>;");
+      "external const factory Foo()=prefix.Bar<List<T>,T>;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = prefix.Bar<T>.baz;");
+      "external const factory Foo()=prefix.Bar<T>.baz;");
   testUnparseMemberAndAsMemberOfFoo(
-      "external const factory Foo() = prefix.Bar<List<T>,T>.baz;");
+      "external const factory Foo()=prefix.Bar<List<T>,T>.baz;");
 }
 
 testClassDeclarations() {
   testUnparseTopLevelWithMetadata('class Foo{}');
   testUnparseTopLevelWithMetadata('abstract class Foo{}');
   testUnparseTopLevelWithMetadata('class Fisk{operator-(x){}}');
 }
 
 testMixinApplications() {
   testUnparseTopLevelWithMetadata('class C = S with M;');
@@ skipping 93 matching lines @@
   testPart();
   testPartOf();
   testCombinators();
   testDeferredImport();
   testRedirectingFactoryConstructors();
   testClassDeclarations();
   testMixinApplications();
   testParameters();
   testSymbolLiterals();
 }