Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/resolution/secret_tree_element.dart

Issue 422483002: Mix in [TreeElementMixin] only on nodes that need it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Encapsulates the field [TreeElementMixin._element]. 6 * Encapsulates the field [TreeElementMixin._element].
7 * 7 *
8 * This library is an implementation detail of dart2js, and should not 8 * This library is an implementation detail of dart2js, and should not
9 * be imported except by resolution and tree node libraries, or for 9 * be imported except by resolution and tree node libraries, or for
10 * testing. 10 * testing.
11 * 11 *
12 * We have taken great care to ensure AST nodes can be cached between 12 * We have taken great care to ensure AST nodes can be cached between
13 * compiler instances. Part of this requires that we always access 13 * compiler instances. Part of this requires that we always access
14 * resolution results through TreeElements. 14 * resolution results through TreeElements.
15 * 15 *
16 * So please, do not add additional elements to this library, and do 16 * So please, do not add additional elements to this library, and do
17 * not import it. 17 * not import it.
18 */ 18 */
19 library secret_tree_element; 19 library secret_tree_element;
20 20
21 /** 21 import '../dart2jslib.dart' show invariant, Spannable;
22 * The superclass of all AST nodes. 22
23 */ 23 /// The superclass of all AST nodes.
24 abstract class TreeElementMixin { 24 ///
25 /// This is the empty implementation which does not allow association of
26 /// elements.
27 abstract class TreeElementMixin implements Spannable {
floitsch 2014/07/25 12:30:08 Let's go for an interface and two implementations:
Johnni Winther 2014/08/04 06:59:09 Done.
25 // Deliberately using [Object] here to thwart code completion. 28 // Deliberately using [Object] here to thwart code completion.
26 // You're not really supposed to access this field anyways. 29 // You're not really supposed to access this field anyways.
30 Object get _element => null;
31 set _element(_) {
32 assert(invariant(this, false,
33 message: "Elements cannot be associated with ${runtimeType}."));
34 }
35 }
36
37 /// Actual implementation of [TreeElementMixin] which stores the associated
38 /// element in the private field [_element].
39 ///
40 /// This class is mixed into the nodes classes that are actually associated with
41 /// elements.
42 abstract class TreeElementMixinImpl implements TreeElementMixin {
27 Object _element; 43 Object _element;
28 } 44 }
29 45
30 /** 46 /**
31 * Do not call this method directly. Instead, use an instance of 47 * Do not call this method directly. Instead, use an instance of
32 * TreeElements. 48 * TreeElements.
33 * 49 *
34 * Using [Object] as return type to thwart code completion. 50 * Using [Object] as return type to thwart code completion.
35 */ 51 */
36 Object getTreeElement(TreeElementMixin node) { 52 Object getTreeElement(TreeElementMixin node) => node._element;
37 return node._element;
38 }
39 53
40 /** 54 /**
41 * Do not call this method directly. Instead, use an instance of 55 * Do not call this method directly. Instead, use an instance of
42 * TreeElements. 56 * TreeElements.
43 */ 57 */
44 void setTreeElement(TreeElementMixin node, Object value) { 58 void setTreeElement(TreeElementMixin node, Object value) {
45 node._element = value; 59 node._element = value;
46 } 60 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698