sdk/lib/_internal/compiler/implementation/tree_validator.dart - Issue 422483002: Mix in [TreeElementMixin] only on nodes that need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/tree_validator.dart

Issue 422483002: Mix in [TreeElementMixin] only on nodes that need it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/tree/unparser.dart ('k') | sdk/lib/_internal/compiler/implementation/typechecker.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/tree_validator.dart

diff --git a/sdk/lib/_internal/compiler/implementation/tree_validator.dart b/sdk/lib/_internal/compiler/implementation/tree_validator.dart

index 399ad60ed6ea70ac4bca52bdfcc74b36ce7b46aa..e3dfcc9aec098c39e6d97957c192b29bf97c6297 100644

--- a/sdk/lib/_internal/compiler/implementation/tree_validator.dart

+++ b/sdk/lib/_internal/compiler/implementation/tree_validator.dart

@@ -58,7 +58,7 @@ class ValidatorVisitor extends Visitor {

}

visitReturn(Return node) {

- if (!node.isRedirectingFactoryBody && node.hasExpression) {

+ if (node.hasExpression) {

// We allow non-expression expressions in Return nodes, but only when

// using them to hold redirecting factory constructors.

expect(node, node.expression.asExpression() != null);