Issue 415513002: - Fix a lot of warnings generated by -Wshorten-64-to-32

Issue 415513002: - Fix a lot of warnings generated by -Wshorten-64-to-32 (Closed)

Created:
6 years, 5 months ago by Ivan Posva

Modified:
6 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix a lot of warnings generated by -Wshorten-64-to-32 when compiling for ia32 on Mac. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38499

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -129 lines)			Patch
M	runtime/bin/run_vm_tests.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/platform/thread_macos.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	runtime/platform/utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/platform/utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/benchmark_test.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/dart.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View		4 chunks	+5 lines, -16 lines	0 comments	Download
M	runtime/vm/object.cc	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	runtime/vm/os.h	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/os_android.cc	View		5 chunks	+4 lines, -17 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View		5 chunks	+4 lines, -17 lines	0 comments	Download
M	runtime/vm/os_macos.cc	View		2 chunks	+8 lines, -17 lines	0 comments	Download
M	runtime/vm/os_test.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/os_win.cc	View		2 chunks	+2 lines, -10 lines	0 comments	Download
M	runtime/vm/port_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/profiler.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/ring_buffer.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/snapshot.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/snapshot.cc	View		5 chunks	+16 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

This should fix all warning in the VM proper when compiling for ia32 on the ...

6 years, 5 months ago (2014-07-23 11:18:38 UTC) #1

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/415513002/diff/20001/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/415513002/diff/20001/runtime/vm/intermediate_language.cc#newcode2736 runtime/vm/intermediate_language.cc:2736: ((limit > 0) && (limit < 64) && ...

6 years, 5 months ago (2014-07-23 13:00:05 UTC) #2

Ivan Posva

Thanks, -Ivan https://codereview.chromium.org/415513002/diff/20001/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/415513002/diff/20001/runtime/vm/intermediate_language.cc#newcode2736 runtime/vm/intermediate_language.cc:2736: ((limit > 0) && (limit < 64) ...

6 years, 5 months ago (2014-07-23 14:05:38 UTC) #3

Ivan Posva

6 years, 5 months ago (2014-07-23 14:10:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r38499 (presubmit successful).

Expand Messages | Collapse Messages