Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: runtime/vm/dart.cc

Issue 415513002: - Fix a lot of warnings generated by -Wshorten-64-to-32 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/benchmark_test.h ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
===================================================================
--- runtime/vm/dart.cc (revision 38492)
+++ runtime/vm/dart.cc (working copy)
@@ -232,9 +232,14 @@
// TODO(turnidge): Remove once length is not part of the snapshot.
const Snapshot* snapshot = Snapshot::SetupFromBuffer(snapshot_buffer);
+ if (snapshot == NULL) {
+ const String& message = String::Handle(
+ String::New("Invalid snapshot."));
+ return ApiError::New(message);
+ }
ASSERT(snapshot->kind() == Snapshot::kFull);
if (FLAG_trace_isolates) {
- OS::Print("Size of isolate snapshot = %" Pd64 "\n", snapshot->length());
+ OS::Print("Size of isolate snapshot = %" Pd "\n", snapshot->length());
}
SnapshotReader reader(snapshot->content(), snapshot->length(),
Snapshot::kFull, isolate);
« no previous file with comments | « runtime/vm/benchmark_test.h ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698