Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 415513002: - Fix a lot of warnings generated by -Wshorten-64-to-32 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/disassembler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 38492)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -4743,7 +4743,7 @@
NativeArguments* arguments = reinterpret_cast<NativeArguments*>(args);
ASSERT(arguments->isolate() == Isolate::Current());
if (Smi::IsValid(retval)) {
- Api::SetSmiReturnValue(arguments, retval);
+ Api::SetSmiReturnValue(arguments, static_cast<intptr_t>(retval));
} else {
// Slow path for Mints and Bigints.
ASSERT_CALLBACK_STATE(arguments->isolate());
@@ -4862,7 +4862,7 @@
" snapshot.", CURRENT_FUNC);
}
if (snapshot->length() != buffer_len) {
- return Api::NewError("%s: 'buffer_len' of %" Pd " is not equal to %" Pd64
+ return Api::NewError("%s: 'buffer_len' of %" Pd " is not equal to %" Pd
" which is the expected length in the snapshot.",
CURRENT_FUNC, buffer_len, snapshot->length());
}
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/disassembler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698