- Fix a lot of warnings generated by -Wshorten-64-to-32

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/bit_vector.h"
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
@@ skipping 2711 matching lines @@
   return false;
 }
 
 
 RangeBoundary RangeBoundary::Shl(const RangeBoundary& value_boundary,
                                  int64_t shift_count,
                                  const RangeBoundary& overflow) {
   ASSERT(value_boundary.IsConstant());
   ASSERT(shift_count >= 0);
   int64_t limit = 64 - shift_count;
-  int64_t value = static_cast<int64_t>(value_boundary.ConstantValue());
+  int64_t value = value_boundary.ConstantValue();
 
   if ((value == 0) ||
       (shift_count == 0) ||
-      ((limit > 0) && (Utils::IsInt(limit, value)))) {
+      ((limit > 0) && (limit < 64) &&

[Vyacheslav Egorov (Google), 2014/07/23 13:00:05]

limit < 64 is always true here because shift_count >= 0 and !(shift_count == 0)
at this point.

[Ivan Posva, 2014/07/23 14:05:38]

Removed.

+       Utils::IsInt(static_cast<int>(limit), value))) {
     // Result stays in 64 bit range.
     int64_t result = value << shift_count;
     return RangeBoundary(result);
   }
 
   return overflow;
 }
 
 
 static RangeBoundary CanonicalizeBoundary(const RangeBoundary& a,
@@ skipping 942 matching lines @@
   ASSERT(result_min != NULL);
   ASSERT(result_max != NULL);
 
   const int64_t left_max = ConstantAbsMax(left_range);
   const int64_t right_max = ConstantAbsMax(right_range);
   if ((left_max <= -kSmiMin) && (right_max <= -kSmiMin) &&
       ((left_max == 0) || (right_max <= kMaxInt64 / left_max))) {
     // Product of left and right max values stays in 64 bit range.
     const int64_t mul_max = left_max * right_max;
     if (Smi::IsValid(mul_max) && Smi::IsValid(-mul_max)) {
-      const intptr_t r_min =
+      const int64_t r_min =
           OnlyPositiveOrZero(*left_range, *right_range) ? 0 : -mul_max;
       *result_min = RangeBoundary::FromConstant(r_min);
-      const intptr_t r_max =
+      const int64_t r_max =
           OnlyNegativeOrZero(*left_range, *right_range) ? 0 : mul_max;
       *result_max = RangeBoundary::FromConstant(r_max);
       return true;
     }
   }
   return false;
 }
 
 
 // Both the a and b ranges are >= 0.
@@ skipping 396 matching lines @@
     case Token::kTRUNCDIV: return 0;
     case Token::kMOD: return 1;
     default: UNIMPLEMENTED(); return -1;
   }
 }
 
 
 #undef __
 
 }  // namespace dart