Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 365983002: Make isolate specific stub code accessors instance methods instead (Closed)

Created:
6 years, 5 months ago by siva
Modified:
6 years, 5 months ago
Reviewers:
zra, Cutch, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make isolate specific stub code accessors instance methods instead of static. This allows use of isolate without having to call Isolate::Current() when using these accessors. R=johnmccutchan@google.com, srdjan@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=38040

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -231 lines) Patch
M runtime/vm/assembler_arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/assembler_x64.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/code_patcher_arm64_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_patcher_arm_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_patcher_ia32_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_patcher_mips_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_patcher_x64_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 14 chunks +28 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 14 chunks +28 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 14 chunks +28 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 15 chunks +28 lines, -17 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 14 chunks +28 lines, -17 lines 0 comments Download
M runtime/vm/instructions_arm64_test.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/instructions_arm_test.cc View 5 chunks +20 lines, -14 lines 0 comments Download
M runtime/vm/instructions_ia32_test.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/instructions_mips_test.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/instructions_x64_test.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 12 chunks +37 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 11 chunks +33 lines, -11 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 13 chunks +38 lines, -14 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 8 chunks +21 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 11 chunks +33 lines, -12 lines 0 comments Download
M runtime/vm/stub_code.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/stub_code.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
6 years, 5 months ago (2014-07-02 18:57:43 UTC) #1
Cutch
lgtm
6 years, 5 months ago (2014-07-02 19:17:00 UTC) #2
zra
lgtm
6 years, 5 months ago (2014-07-02 20:23:36 UTC) #3
srdjan
lgtm
6 years, 5 months ago (2014-07-07 17:57:01 UTC) #4
siva
6 years, 5 months ago (2014-07-07 21:38:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r38040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698