Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 365983002: Make isolate specific stub code accessors instance methods instead (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/code_patcher_arm64_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.cc
===================================================================
--- runtime/vm/assembler_x64.cc (revision 37923)
+++ runtime/vm/assembler_x64.cc (working copy)
@@ -28,7 +28,8 @@
comments_() {
// Far branching mode is only needed and implemented for MIPS and ARM.
ASSERT(!use_far_branches);
- if (Isolate::Current() != Dart::vm_isolate()) {
+ Isolate* isolate = Isolate::Current();
+ if (isolate != Dart::vm_isolate()) {
object_pool_ = GrowableObjectArray::New(Heap::kOld);
// These objects and labels need to be accessible through every pool-pointer
@@ -48,8 +49,9 @@
const Smi& vacant = Smi::Handle(Smi::New(0xfa >> kSmiTagShift));
- if (StubCode::UpdateStoreBuffer_entry() != NULL) {
- FindExternalLabel(&StubCode::UpdateStoreBufferLabel(), kNotPatchable);
+ StubCode* stub_code = isolate->stub_code();
+ if (stub_code->UpdateStoreBuffer_entry() != NULL) {
+ FindExternalLabel(&stub_code->UpdateStoreBufferLabel(), kNotPatchable);
} else {
object_pool_.Add(vacant, Heap::kOld);
patchable_pool_entries_.Add(kNotPatchable);
@@ -2707,7 +2709,8 @@
if (object != RAX) {
movq(RAX, object);
}
- Call(&StubCode::UpdateStoreBufferLabel(), PP);
+ StubCode* stub_code = Isolate::Current()->stub_code();
+ Call(&stub_code->UpdateStoreBufferLabel(), PP);
if (value != RAX) popq(RAX);
Bind(&done);
}
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/code_patcher_arm64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698