Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: runtime/vm/instructions_arm_test.cc

Issue 365983002: Make isolate specific stub code accessors instance methods instead (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_arm64_test.cc ('k') | runtime/vm/instructions_ia32_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_arm_test.cc
===================================================================
--- runtime/vm/instructions_arm_test.cc (revision 37923)
+++ runtime/vm/instructions_arm_test.cc (working copy)
@@ -16,7 +16,8 @@
#define __ assembler->
ASSEMBLER_TEST_GENERATE(Call, assembler) {
- __ BranchLinkPatchable(&StubCode::InvokeDartCodeLabel());
+ StubCode* stub_code = Isolate::Current()->stub_code();
+ __ BranchLinkPatchable(&stub_code->InvokeDartCodeLabel());
__ Ret();
}
@@ -27,14 +28,16 @@
// before the end of the code buffer.
CallPattern call(test->entry() + test->code().Size() - Instr::kInstrSize,
test->code());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ StubCode* stub_code = Isolate::Current()->stub_code();
+ EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
call.TargetAddress());
}
ASSEMBLER_TEST_GENERATE(Jump, assembler) {
- __ BranchPatchable(&StubCode::InvokeDartCodeLabel());
- __ BranchPatchable(&StubCode::AllocateArrayLabel());
+ StubCode* stub_code = Isolate::Current()->stub_code();
+ __ BranchPatchable(&stub_code->InvokeDartCodeLabel());
+ __ BranchPatchable(&stub_code->AllocateArrayLabel());
}
@@ -45,21 +48,22 @@
VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
instrs.size(),
VirtualMemory::kReadWrite);
+ StubCode* stub_code = Isolate::Current()->stub_code();
EXPECT(status);
JumpPattern jump1(test->entry(), test->code());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
jump1.TargetAddress());
JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
test->code());
- EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
+ EXPECT_EQ(stub_code->AllocateArrayLabel().address(),
jump2.TargetAddress());
uword target1 = jump1.TargetAddress();
uword target2 = jump2.TargetAddress();
jump1.SetTargetAddress(target2);
jump2.SetTargetAddress(target1);
- EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
+ EXPECT_EQ(stub_code->AllocateArrayLabel().address(),
jump1.TargetAddress());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
jump2.TargetAddress());
}
@@ -67,9 +71,10 @@
#if defined(USING_SIMULATOR)
ASSEMBLER_TEST_GENERATE(JumpARMv6, assembler) {
// ARMv7 is the default.
+ StubCode* stub_code = Isolate::Current()->stub_code();
HostCPUFeatures::set_arm_version(ARMv6);
- __ BranchPatchable(&StubCode::InvokeDartCodeLabel());
- __ BranchPatchable(&StubCode::AllocateArrayLabel());
+ __ BranchPatchable(&stub_code->InvokeDartCodeLabel());
+ __ BranchPatchable(&stub_code->AllocateArrayLabel());
HostCPUFeatures::set_arm_version(ARMv7);
}
@@ -82,21 +87,22 @@
VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
instrs.size(),
VirtualMemory::kReadWrite);
+ StubCode* stub_code = Isolate::Current()->stub_code();
EXPECT(status);
JumpPattern jump1(test->entry(), test->code());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
jump1.TargetAddress());
JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
test->code());
- EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
+ EXPECT_EQ(stub_code->AllocateArrayLabel().address(),
jump2.TargetAddress());
uword target1 = jump1.TargetAddress();
uword target2 = jump2.TargetAddress();
jump1.SetTargetAddress(target2);
jump2.SetTargetAddress(target1);
- EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
+ EXPECT_EQ(stub_code->AllocateArrayLabel().address(),
jump1.TargetAddress());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
jump2.TargetAddress());
HostCPUFeatures::set_arm_version(ARMv7);
}
« no previous file with comments | « runtime/vm/instructions_arm64_test.cc ('k') | runtime/vm/instructions_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698