Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: runtime/vm/stub_code.cc

Issue 365983002: Make isolate specific stub code accessors instance methods instead (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code.h ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code.cc
===================================================================
--- runtime/vm/stub_code.cc (revision 37923)
+++ runtime/vm/stub_code.cc (working copy)
@@ -96,9 +96,9 @@
bool StubCode::InInvocationStubForIsolate(Isolate* isolate, uword pc) {
- StubEntry* invoke_dart_entry = isolate->stub_code()->InvokeDartCode_entry_;
- uword entry = invoke_dart_entry->EntryPoint();
- uword size = invoke_dart_entry->Size();
+ StubCode* stub_code = isolate->stub_code();
+ uword entry = stub_code->InvokeDartCodeEntryPoint();
+ uword size = stub_code->InvokeDartCodeSize();
return (pc >= entry) && (pc < (entry + size));
}
@@ -142,16 +142,22 @@
const char* StubCode::NameOfStub(uword entry_point) {
-#define STUB_CODE_TESTER(name) \
+#define VM_STUB_CODE_TESTER(name) \
if ((name##_entry() != NULL) && (entry_point == name##EntryPoint())) { \
return ""#name; \
}
+ VM_STUB_CODE_LIST(VM_STUB_CODE_TESTER);
- VM_STUB_CODE_LIST(STUB_CODE_TESTER);
+#define STUB_CODE_TESTER(name) \
+ if ((isolate->stub_code()->name##_entry() != NULL) && \
+ (entry_point == isolate->stub_code()->name##EntryPoint())) { \
+ return ""#name; \
+ }
Isolate* isolate = Isolate::Current();
if ((isolate != NULL) && (isolate->stub_code() != NULL)) {
STUB_CODE_LIST(STUB_CODE_TESTER);
}
+#undef VM_STUB_CODE_TESTER
#undef STUB_CODE_TESTER
return NULL;
}
« no previous file with comments | « runtime/vm/stub_code.h ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698