Issue 363093004: Use Object::null_object() instead of Object::ZoneHandle() when a null object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 363093004: Use Object::null_object() instead of Object::ZoneHandle() when a null object (Closed)

Created:
6 years, 5 months ago by siva

Modified:
6 years, 5 months ago

Reviewers:
zra, srdjan, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use Object::null_object() instead of Object::ZoneHandle() when a null object handle is desired. This is more efficient as it does not result in allocation of a ZoneHandle and access to Isolate::Current(). R=srdjan@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=38044

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -52 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm64_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/stub_code_mips_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM. I wonder if it would be more readable if "s/null_object/null_handle/"?

6 years, 5 months ago (2014-07-07 17:50:15 UTC) #3

siva

6 years, 5 months ago (2014-07-07 22:15:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r38044 (presubmit successful).

Expand Messages | Collapse Messages