runtime/vm/parser.cc - Issue 363093004: Use Object::null_object() instead of Object::ZoneHandle() when a null object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 363093004: Use Object::null_object() instead of Object::ZoneHandle() when a null object (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 37955)

+++ runtime/vm/parser.cc (working copy)

@@ -1329,7 +1329,7 @@

intptr_t index = i - desc.PositionalCount();

p.name = &String::ZoneHandle(I, desc.NameAt(index));

p.type = &Type::ZoneHandle(I, Type::DynamicType());

- p.default_value = &Object::ZoneHandle();

+ p.default_value = &Object::null_object();

params.parameters->Add(p);

params.num_optional_parameters++;

params.has_optional_named_parameters = true;

@@ -1697,7 +1697,7 @@

params->has_optional_named_parameters) {

// Implicit default value is null.

params->num_optional_parameters++;

- parameter.default_value = &Object::ZoneHandle();

+ parameter.default_value = &Object::null_object();

} else {

params->num_fixed_parameters++;

ASSERT(params->num_optional_parameters == 0);

« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/stub_code_arm64_test.cc » ('j') | no next file with comments »