runtime/vm/flow_graph_compiler_arm.cc - Issue 363093004: Use Object::null_object() instead of Object::ZoneHandle() when a null object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 363093004: Use Object::null_object() instead of Object::ZoneHandle() when a null object (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_arm.cc

===================================================================

--- runtime/vm/flow_graph_compiler_arm.cc (revision 37955)

+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)

@@ -593,7 +593,7 @@

// Generate runtime call.

// Load instantiator (R2) and its type arguments (R1).

__ ldm(IA, SP, (1 << R1) | (1 << R2));

- __ PushObject(Object::ZoneHandle()); // Make room for the result.

+ __ PushObject(Object::null_object()); // Make room for the result.

__ Push(R0); // Push the instance.

__ PushObject(type); // Push the type.

// Push instantiator (R2) and its type arguments (R1).

@@ -659,7 +659,7 @@

// Generate throw new TypeError() if the type is malformed or malbounded.

if (dst_type.IsMalformedOrMalbounded()) {

- __ PushObject(Object::ZoneHandle()); // Make room for the result.

+ __ PushObject(Object::null_object()); // Make room for the result.

__ Push(R0); // Push the source object.

__ PushObject(dst_name); // Push the name of the destination.

__ PushObject(dst_type); // Push the type of the destination.

@@ -685,7 +685,7 @@

__ Bind(&runtime_call);

// Load instantiator (R2) and its type arguments (R1).

__ ldm(IA, SP, (1 << R1) | (1 << R2));

- __ PushObject(Object::ZoneHandle()); // Make room for the result.

+ __ PushObject(Object::null_object()); // Make room for the result.

__ Push(R0); // Push the source object.

__ PushObject(dst_type); // Push the type of the destination.

// Push instantiator (R2) and its type arguments (R1).

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »