runtime/vm/stub_code_arm64_test.cc - Issue 363093004: Use Object::null_object() instead of Object::ZoneHandle() when a null object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_arm64_test.cc

Issue 363093004: Use Object::null_object() instead of Object::ZoneHandle() when a null object (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_arm64_test.cc

===================================================================

--- runtime/vm/stub_code_arm64_test.cc (revision 37955)

+++ runtime/vm/stub_code_arm64_test.cc (working copy)

@@ -44,12 +44,11 @@

const int argc = 2;

const Smi& smi1 = Smi::ZoneHandle(Smi::New(value1));

const Smi& smi2 = Smi::ZoneHandle(Smi::New(value2));

- const Object& result = Object::ZoneHandle();

const Context& context = Context::ZoneHandle(Context::New(0, Heap::kOld));

ASSERT(context.isolate() == Isolate::Current());

__ EnterDartFrame(0);

__ LoadObject(CTX, context, PP);

- __ PushObject(result, PP); // Push Null object for return value.

+ __ PushObject(Object::null_object(), PP); // Push Null obj for return value.

__ PushObject(smi1, PP); // Push argument 1 smi1.

__ PushObject(smi2, PP); // Push argument 2 smi2.

ASSERT(kTestSmiSubRuntimeEntry.argument_count() == argc);

« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/stub_code_arm_test.cc » ('j') | no next file with comments »