Issue 337183002: Refactor creation of FinalizablePersistentHandle into proper factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337183002: Refactor creation of FinalizablePersistentHandle into proper factory. (Closed)

Created:
6 years, 6 months ago by koda

Modified:
6 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Refactor creation of FinalizablePersistentHandle into proper factory. This exposes an issue (19482) with the API and external size tracking. BUG=dart:19482 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37381

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -26 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+7 lines, -11 lines	0 comments	Download
M	runtime/vm/dart_api_state.h	View	3 chunks	+38 lines, -7 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+9 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

koda

6 years, 6 months ago (2014-06-16 23:55:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r37381 (presubmit successful).