Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: runtime/vm/object.cc

Issue 337183002: Refactor creation of FinalizablePersistentHandle into proper factory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_state.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 37360)
+++ runtime/vm/object.cc (working copy)
@@ -16870,14 +16870,15 @@
Dart_WeakPersistentHandleFinalizer callback) {
ASSERT((callback != NULL && peer != NULL) ||
(callback == NULL && peer == NULL));
- ApiState* state = Isolate::Current()->api_state();
- ASSERT(state != NULL);
- FinalizablePersistentHandle* weak_ref =
- state->weak_persistent_handles().AllocateHandle();
- weak_ref->set_raw(referent);
- weak_ref->set_peer(peer);
- weak_ref->set_callback(callback);
- return weak_ref;
+ const bool is_prologue = false;
+ // TODO(19482): Make API consistent for external size of strings/typed data.
+ const intptr_t external_size = 0;
+ return FinalizablePersistentHandle::New(Isolate::Current(),
+ is_prologue,
+ referent,
+ peer,
+ callback,
+ external_size);
}
« no previous file with comments | « runtime/vm/dart_api_state.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698