Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 337183002: Refactor creation of FinalizablePersistentHandle into proper factory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/dart_api_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 37360)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -947,20 +947,16 @@
void* peer,
intptr_t external_allocation_size,
Dart_WeakPersistentHandleFinalizer callback) {
- ApiState* state = isolate->api_state();
- ASSERT(state != NULL);
REUSABLE_OBJECT_HANDLESCOPE(isolate);
Object& ref = isolate->ObjectHandle();
ref = Api::UnwrapHandle(object);
- FinalizablePersistentHandle* finalizable_ref = is_prologue ?
- state->prologue_weak_persistent_handles().AllocateHandle() :
- state->weak_persistent_handles().AllocateHandle();
-
- finalizable_ref->set_raw(ref);
- finalizable_ref->set_peer(peer);
- finalizable_ref->set_callback(callback);
- finalizable_ref->SetExternalSize(external_allocation_size, isolate);
- finalizable_ref->SetPrologueWeakPersistent(is_prologue);
+ FinalizablePersistentHandle* finalizable_ref =
+ FinalizablePersistentHandle::New(isolate,
+ is_prologue,
+ ref,
+ peer,
+ callback,
+ external_allocation_size);
return finalizable_ref->apiHandle();
}
« no previous file with comments | « no previous file | runtime/vm/dart_api_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698