Refactor creation of FinalizablePersistentHandle into proper factory.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
@@ skipping 929 matching lines @@
 }
 
 
 static Dart_WeakPersistentHandle AllocateFinalizableHandle(
     Isolate* isolate,
     Dart_Handle object,
     bool is_prologue,
     void* peer,
     intptr_t external_allocation_size,
     Dart_WeakPersistentHandleFinalizer callback) {
-  ApiState* state = isolate->api_state();
-  ASSERT(state != NULL);
   REUSABLE_OBJECT_HANDLESCOPE(isolate);
   Object& ref = isolate->ObjectHandle();
   ref = Api::UnwrapHandle(object);
-  FinalizablePersistentHandle* finalizable_ref = is_prologue ?
-      state->prologue_weak_persistent_handles().AllocateHandle() :
-      state->weak_persistent_handles().AllocateHandle();
-
-  finalizable_ref->set_raw(ref);
-  finalizable_ref->set_peer(peer);
-  finalizable_ref->set_callback(callback);
-  finalizable_ref->SetExternalSize(external_allocation_size, isolate);
-  finalizable_ref->SetPrologueWeakPersistent(is_prologue);
+  FinalizablePersistentHandle* finalizable_ref =
+      FinalizablePersistentHandle::New(isolate,
+                                       is_prologue,
+                                       ref,
+                                       peer,
+                                       callback,
+                                       external_allocation_size);
   return finalizable_ref->apiHandle();
 }
 
 
 DART_EXPORT Dart_WeakPersistentHandle Dart_NewWeakPersistentHandle(
     Dart_Handle object,
     void* peer,
     intptr_t external_allocation_size,
     Dart_WeakPersistentHandleFinalizer callback) {
   Isolate* isolate = Isolate::Current();
@@ skipping 4218 matching lines @@
 
 
 DART_EXPORT void Dart_RegisterRootServiceRequestCallback(
     const char* name,
     Dart_ServiceRequestCallback callback,
     void* user_data) {
   Service::RegisterRootEmbedderCallback(name, callback, user_data);
 }
 
 }  // namespace dart