Issue 327003004: Tweaks for review comments.

Issue 327003004: Tweaks for review comments. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Tweaks for review comments. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37198

Patch Set 1 #

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -20 lines)			Patch
M	pkg/analysis_server/lib/src/index/page_node_manager.dart	View	9 chunks	+19 lines, -14 lines	2 comments	Download
M	pkg/analysis_server/test/index/b_plus_tree_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/index/file_page_manager_test.dart	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/index/page_node_manager_test.dart	View	4 chunks	+18 lines, -2 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

lgtm, assuming read() is changed to make a copy. https://codereview.chromium.org/327003004/diff/1/pkg/analysis_server/lib/src/index/page_node_manager.dart File pkg/analysis_server/lib/src/index/page_node_manager.dart (right): https://codereview.chromium.org/327003004/diff/1/pkg/analysis_server/lib/src/index/page_node_manager.dart#newcode187 pkg/analysis_server/lib/src/index/page_node_manager.dart:187: ...

6 years, 6 months ago (2014-06-10 20:23:40 UTC) #2

scheglov

https://codereview.chromium.org/327003004/diff/1/pkg/analysis_server/lib/src/index/page_node_manager.dart File pkg/analysis_server/lib/src/index/page_node_manager.dart (right): https://codereview.chromium.org/327003004/diff/1/pkg/analysis_server/lib/src/index/page_node_manager.dart#newcode187 pkg/analysis_server/lib/src/index/page_node_manager.dart:187: return page; On 2014/06/10 20:23:40, Paul Berry wrote: > ...

6 years, 6 months ago (2014-06-10 20:36:55 UTC) #4

scheglov

6 years, 6 months ago (2014-06-10 20:37:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r37198 (presubmit successful).

Expand Messages | Collapse Messages