Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: pkg/analysis_server/test/index/file_page_manager_test.dart

Issue 327003004: Tweaks for review comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/index/file_page_manager_test.dart
diff --git a/pkg/analysis_server/test/index/file_page_manager_test.dart b/pkg/analysis_server/test/index/file_page_manager_test.dart
index 1e72c8dc650bcc1e86a8c40d0088aa09de662c8a..1c119423abd77729a93f21af2b8f423a62a63423 100644
--- a/pkg/analysis_server/test/index/file_page_manager_test.dart
+++ b/pkg/analysis_server/test/index/file_page_manager_test.dart
@@ -4,6 +4,7 @@
library test.index.file_page_manager;
+import 'dart:collection';
import 'dart:io';
import 'dart:math';
import 'dart:typed_data';
@@ -70,7 +71,7 @@ class _FilePageManagerTest {
int tryCount = 1000;
Set<int> keys = new Set<int>();
{
- Random random = new Random();
+ Random random = new Random(37);
for (int i = 0; i < tryCount; i++) {
int key = random.nextInt(maxKey);
keys.add(key);
@@ -83,13 +84,19 @@ class _FilePageManagerTest {
}
// remove random keys
{
- Random random = new Random();
+ Random random = new Random(37);
+ Set<int> removedKeys = new HashSet<int>();
for (int key in new Set<int>.from(keys)) {
if (random.nextBool()) {
+ removedKeys.add(key);
keys.remove(key);
expect(tree.remove(key), 'V$key');
}
}
+ // check the removed keys are actually gone
+ for (int key in removedKeys) {
+ expect(tree.find(key), isNull);
+ }
}
// find every remaining key
for (int key in keys) {

Powered by Google App Engine
This is Rietveld 408576698