Tweaks for review comments.

pkg/analysis_server/test/index/page_node_manager_test.dart

Index: pkg/analysis_server/test/index/page_node_manager_test.dart
diff --git a/pkg/analysis_server/test/index/page_node_manager_test.dart b/pkg/analysis_server/test/index/page_node_manager_test.dart
index b2e2eaeeaeab777284d1dd93a79b084f3b2ce3be..78b1281314ab33e79b0233e31d0a5d8c27153803 100644
--- a/pkg/analysis_server/test/index/page_node_manager_test.dart
+++ b/pkg/analysis_server/test/index/page_node_manager_test.dart
@@ -53,7 +53,7 @@ _treeWithPageNodeManager() {
   int tryCount = 1000;
   Set<int> keys = new Set<int>();
   {
-    Random random = new Random();
+    Random random = new Random(37);
     for (int i = 0; i < tryCount; i++) {
       int key = random.nextInt(maxKey);
       keys.add(key);
@@ -66,7 +66,7 @@ _treeWithPageNodeManager() {
   }
   // remove random keys
   {
-    Random random = new Random();
+    Random random = new Random(37);
     for (int key in new Set<int>.from(keys)) {
       if (random.nextBool()) {
         keys.remove(key);
@@ -229,6 +229,14 @@ class _FixedStringCodecTest {
     // decode
     expect(codec.decode(buffer), 'AB');
   }
+
+  test_russian() {
+    // encode
+    codec.encode(buffer, 'ЩУКА');
+    expect(bytes, [0, 4, 4, 41, 4, 35, 4, 26, 4, 16]);
+    // decode
+    expect(codec.decode(buffer), 'ЩУКА');
+  }
 }
 
 
@@ -286,6 +294,14 @@ class _MemoryPageManagerTest {
       manager.write(42, page);
     }, throws);
   }
+
+  test_write_invalidLenght() {

[Paul Berry, 2014/06/10 20:23:40]

"Length" misspelled

[scheglov, 2014/06/10 20:36:55]

Done.

+    int id = manager.alloc();
+    Uint8List page = new Uint8List(0);
+    expect(() {
+      manager.write(id, page);
+    }, throws);
+  }
 }