Tweaks for review comments.

pkg/analysis_server/test/index/page_node_manager_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.index.page_node_manager;
 
 import 'dart:math';
 import 'dart:typed_data';
 
 import 'package:analysis_server/src/index/b_plus_tree.dart';
@@ skipping 35 matching lines @@
   int pageSize = 256;
   MemoryPageManager pageManager = new MemoryPageManager(pageSize);
   NodeManager<int, String, int> nodeManager = new PageNodeManager<int, String>(
       pageManager, Uint32Codec.INSTANCE, new FixedStringCodec(7));
 //  NodeManager<int, String, int> nodeManager = new MemoryNodeManager();
   BPlusTree<int, String, int> tree = new BPlusTree(_intComparator, nodeManager);
   int maxKey = 1000000;
   int tryCount = 1000;
   Set<int> keys = new Set<int>();
   {
-    Random random = new Random();
+    Random random = new Random(37);
     for (int i = 0; i < tryCount; i++) {
       int key = random.nextInt(maxKey);
       keys.add(key);
       tree.insert(key, 'V$key');
     }
   }
   // find every
   for (int key in keys) {
     expect(tree.find(key), 'V$key');
   }
   // remove random keys
   {
-    Random random = new Random();
+    Random random = new Random(37);
     for (int key in new Set<int>.from(keys)) {
       if (random.nextBool()) {
         keys.remove(key);
         expect(tree.remove(key), 'V$key');
       }
     }
   }
   // find every remaining key
   for (int key in keys) {
     expect(tree.find(key), 'V$key');
@@ skipping 142 matching lines @@
     }, throws);
   }
 
   test_twoChars() {
     // encode
     codec.encode(buffer, 'AB');
     expect(bytes, [0, 2, 0, 65, 0, 66, 0, 0, 0, 0]);
     // decode
     expect(codec.decode(buffer), 'AB');
   }
+
+  test_russian() {
+    // encode
+    codec.encode(buffer, 'ЩУКА');
+    expect(bytes, [0, 4, 4, 41, 4, 35, 4, 26, 4, 16]);
+    // decode
+    expect(codec.decode(buffer), 'ЩУКА');
+  }
 }
 
 
 @ReflectiveTestCase()
 class _MemoryPageManagerTest {
   static const PAGE_SIZE = 8;
   MemoryPageManager manager = new MemoryPageManager(PAGE_SIZE);
 
   test_alloc() {
     int idA = manager.alloc();
@@ skipping 37 matching lines @@
       expect(page[3], 42);
     }
   }
 
   test_write_doesNotExist() {
     expect(() {
       Uint8List page = new Uint8List(PAGE_SIZE);
       manager.write(42, page);
     }, throws);
   }
+
+  test_write_invalidLenght() {

[Paul Berry, 2014/06/10 20:23:40]

"Length" misspelled

[scheglov, 2014/06/10 20:36:55]

Done.

+    int id = manager.alloc();
+    Uint8List page = new Uint8List(0);
+    expect(() {
+      manager.write(id, page);
+    }, throws);
+  }
 }
 
 
 
 class _NodeManagerMock<K, V, N> extends TypedMock implements NodeManager<K, V,
     N> {
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
 }
 
 
@@ skipping 86 matching lines @@
   }
 
   test_all() {
     // encode
     codec.encode(buffer, 42);
     expect(bytes, [0, 0, 0, 42]);
     // decode
     expect(codec.decode(buffer), 42);
   }
 }