Pass around the current isolate in exception handling code.

Pass around the current isolate in exception handling code.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37409

[rmacnak, 2014-06-10 19:57:55]

This CL omits the handle business in StackFrame::FindExceptionHandler.

baseline
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 199197.54545454547 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 193598.27272727274 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 190772.36363636362 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 247353.55555555556 us.

without handle trick
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 175185.5 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 173046.9166666667 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 174730.5833333333 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 176948.75 us.
  +11%

with handle trick
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 159112.3076923077 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 152431.99999999997 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 159577.61538461538 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 159254.61538461538 us.
  +21%

[rmacnak, 2014-06-10 21:05:34]

with reusable handles
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 163259.5384615385 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 164184.84615384616 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 162125.9230769231 us.
prometheus:dart rmacnak$ dart ParserCombinators.dart 
ParserCombinators(RunTime): 171766.5833333333 us.
+18%

[siva, 2014-06-11 00:04:34]

The isolate parameter LGTM as discussed there is an issue with rethrows which
requires the code array and pc array to be carried over as an existing stack
trace.

https://codereview.chromium.org/326183002/diff/20001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/326183002/diff/20001/runtime/vm/exceptions.cc...
runtime/vm/exceptions.cc:629: Throw(Isolate::Current(), Instance::Cast(result));
Hoist this Isolate::Current() as the first line of this function.
Isolate* isolate = Isolate::Current();

and use it in Object::Handle() also.

[rmacnak, 2014-06-16 19:30:20]

On 2014/06/11 00:04:34, siva wrote:
> The isolate parameter LGTM as discussed there is an issue with rethrows which
> requires the code array and pc array to be carried over as an existing stack
> trace.

I took a look at this, and this change is safe because catch clauses with
rethrow implicitly introduce the stacktrace variable so the original trace is
available to append.

Afterward we 
> https://codereview.chromium.org/326183002/diff/20001/runtime/vm/exceptions.cc
> File runtime/vm/exceptions.cc (right):
> 
>
https://codereview.chromium.org/326183002/diff/20001/runtime/vm/exceptions.cc...
> runtime/vm/exceptions.cc:629: Throw(Isolate::Current(),
Instance::Cast(result));
> Hoist this Isolate::Current() as the first line of this function.
> Isolate* isolate = Isolate::Current();
> 
> and use it in Object::Handle() also.

[rmacnak, 2014-06-17 18:17:19]

Committed patchset #7 manually as r37409.