runtime/vm/exceptions.h - Issue 326183002: Pass around the current isolate in exception handling code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/exceptions.h

Issue 326183002: Pass around the current isolate in exception handling code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/exceptions.h

diff --git a/runtime/vm/exceptions.h b/runtime/vm/exceptions.h

index dab538ba595d2f709d8a09b7865fda50b6663322..8a5b9d39fdc1595e08f1093356f25bcc1f0ea961 100644

--- a/runtime/vm/exceptions.h

+++ b/runtime/vm/exceptions.h

@@ -28,8 +28,10 @@ class Exceptions : AllStatic {

public:

static const char* kCastErrorDstName;

- static void Throw(const Instance& exception);

- static void ReThrow(const Instance& exception, const Instance& stacktrace);

+ static void Throw(Isolate* isolate, const Instance& exception);

+ static void ReThrow(Isolate* isolate,

+ const Instance& exception,

+ const Instance& stacktrace);

static void PropagateError(const Error& error);

// Report a Javascript compatibility warning at the call site given by

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/exceptions.cc » ('j') | no next file with comments »