Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 326183002: Pass around the current isolate in exception handling code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/exceptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 98645440e9dfba5ee507bff502731acd156944ed..1cff83ef4fcb4157ee854ecc68979a1d811b595f 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -2698,7 +2698,7 @@ static RawObject* ThrowArgumentError(const char* exception_message) {
state->UnwindScopes(isolate->top_exit_frame_info());
saved_exception = &Instance::Handle(raw_exception);
}
- Exceptions::Throw(*saved_exception);
+ Exceptions::Throw(isolate, *saved_exception);
const String& message = String::Handle(
String::New("Exception was not thrown, internal error"));
return ApiError::New(message);
@@ -4212,7 +4212,7 @@ DART_EXPORT Dart_Handle Dart_ThrowException(Dart_Handle exception) {
state->UnwindScopes(isolate->top_exit_frame_info());
saved_exception = &Instance::Handle(raw_exception);
}
- Exceptions::Throw(*saved_exception);
+ Exceptions::Throw(isolate, *saved_exception);
return Api::NewError("Exception was not thrown, internal error");
}
@@ -4254,7 +4254,7 @@ DART_EXPORT Dart_Handle Dart_ReThrowException(Dart_Handle exception,
saved_exception = &Instance::Handle(raw_exception);
saved_stacktrace = &Instance::Handle(raw_stacktrace);
}
- Exceptions::ReThrow(*saved_exception, *saved_stacktrace);
+ Exceptions::ReThrow(isolate, *saved_exception, *saved_stacktrace);
return Api::NewError("Exception was not re thrown, internal error");
}
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/exceptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698