Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: runtime/vm/code_generator.cc

Issue 326183002: Pass around the current isolate in exception handling code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/bigint_operations.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc
index 42daa4fd08d80a5da3cbfe569a6c23ac062dc273..123a14189a55afa6ceec8eca56a0d5663652716d 100644
--- a/runtime/vm/code_generator.cc
+++ b/runtime/vm/code_generator.cc
@@ -589,15 +589,18 @@ DEFINE_RUNTIME_ENTRY(BadTypeError, 3) {
DEFINE_RUNTIME_ENTRY(Throw, 1) {
- const Instance& exception = Instance::CheckedHandle(arguments.ArgAt(0));
- Exceptions::Throw(exception);
+ const Instance& exception =
+ Instance::CheckedHandle(isolate, arguments.ArgAt(0));
+ Exceptions::Throw(isolate, exception);
}
DEFINE_RUNTIME_ENTRY(ReThrow, 2) {
- const Instance& exception = Instance::CheckedHandle(arguments.ArgAt(0));
- const Instance& stacktrace = Instance::CheckedHandle(arguments.ArgAt(1));
- Exceptions::ReThrow(exception, stacktrace);
+ const Instance& exception =
+ Instance::CheckedHandle(isolate, arguments.ArgAt(0));
+ const Instance& stacktrace =
+ Instance::CheckedHandle(isolate, arguments.ArgAt(1));
+ Exceptions::ReThrow(isolate, exception, stacktrace);
}
@@ -1064,7 +1067,7 @@ DEFINE_RUNTIME_ENTRY(StackOverflow, 0) {
// into dart code.
const Instance& exception =
Instance::Handle(isolate->object_store()->stack_overflow());
- Exceptions::Throw(exception);
+ Exceptions::Throw(isolate, exception);
UNREACHABLE();
}
« no previous file with comments | « runtime/vm/bigint_operations.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698