Issue 312693008: Add javascript compatibility warnings for strings that are not identical, but

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 312693008: Add javascript compatibility warnings for strings that are not identical, but (Closed)

Created:
6 years, 6 months ago by regis

Modified:
6 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Add javascript compatibility warnings for strings that are not identical, but equal. The vm does not canonicalize all strings as javascript does. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37013

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -12 lines)			Patch
M	runtime/lib/identical.cc	View	1	1 chunk	+32 lines, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	2 chunks	+12 lines, -7 lines	0 comments	Download
M	tests/standalone/javascript_compatibility_errors_test.dart	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	tests/standalone/javascript_compatibility_warnings_test.dart	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

regis

6 years, 6 months ago (2014-06-04 20:47:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r37013 (presubmit successful).