Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 312693008: Add javascript compatibility warnings for strings that are not identical, but (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/cha.h" 9 #include "vm/cha.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 874 matching lines...) Expand 10 before | Expand all | Expand 10 after
885 885
886 void FlowGraphCompiler::GenerateStaticCall(intptr_t deopt_id, 886 void FlowGraphCompiler::GenerateStaticCall(intptr_t deopt_id,
887 intptr_t token_pos, 887 intptr_t token_pos,
888 const Function& function, 888 const Function& function,
889 intptr_t argument_count, 889 intptr_t argument_count,
890 const Array& argument_names, 890 const Array& argument_names,
891 LocationSummary* locs) { 891 LocationSummary* locs) {
892 const Array& arguments_descriptor = 892 const Array& arguments_descriptor =
893 Array::ZoneHandle(ArgumentsDescriptor::New(argument_count, 893 Array::ZoneHandle(ArgumentsDescriptor::New(argument_count,
894 argument_names)); 894 argument_names));
895 if (is_optimizing()) { 895 // Proper reporting of Javascript incompatibilities requires icdata and
896 // may therefore prevent the optimization of some static calls.
897 if (is_optimizing() &&
898 !(FLAG_warn_on_javascript_compatibility &&
899 (MethodRecognizer::RecognizeKind(function) ==
900 MethodRecognizer::kObjectIdentical))) {
896 EmitOptimizedStaticCall(function, arguments_descriptor, argument_count, 901 EmitOptimizedStaticCall(function, arguments_descriptor, argument_count,
897 deopt_id, token_pos, locs); 902 deopt_id, token_pos, locs);
898 } else { 903 } else {
899 EmitUnoptimizedStaticCall(function, arguments_descriptor, argument_count, 904 EmitUnoptimizedStaticCall(function, arguments_descriptor, argument_count,
900 deopt_id, token_pos, locs); 905 deopt_id, token_pos, locs);
901 } 906 }
902 } 907 }
903 908
904 909
905 void FlowGraphCompiler::GenerateNumberTypeCheck(Register kClassIdReg, 910 void FlowGraphCompiler::GenerateNumberTypeCheck(Register kClassIdReg,
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
1303 1308
1304 for (int i = 0; i < len; i++) { 1309 for (int i = 0; i < len; i++) {
1305 sorted->Add(CidTarget(ic_data.GetReceiverClassIdAt(i), 1310 sorted->Add(CidTarget(ic_data.GetReceiverClassIdAt(i),
1306 &Function::ZoneHandle(ic_data.GetTargetAt(i)), 1311 &Function::ZoneHandle(ic_data.GetTargetAt(i)),
1307 ic_data.GetCountAt(i))); 1312 ic_data.GetCountAt(i)));
1308 } 1313 }
1309 sorted->Sort(HighestCountFirst); 1314 sorted->Sort(HighestCountFirst);
1310 } 1315 }
1311 1316
1312 } // namespace dart 1317 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698