runtime/vm/flow_graph_compiler.cc - Issue 312693008: Add javascript compatibility warnings for strings that are not identical, but

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 312693008: Add javascript compatibility warnings for strings that are not identical, but (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

===================================================================

--- runtime/vm/flow_graph_compiler.cc (revision 37011)

+++ runtime/vm/flow_graph_compiler.cc (working copy)

@@ -892,7 +892,12 @@

const Array& arguments_descriptor =

Array::ZoneHandle(ArgumentsDescriptor::New(argument_count,

argument_names));

- if (is_optimizing()) {

+ // Proper reporting of Javascript incompatibilities requires icdata and

+ // may therefore prevent the optimization of some static calls.

+ if (is_optimizing() &&

+ !(FLAG_warn_on_javascript_compatibility &&

+ (MethodRecognizer::RecognizeKind(function) ==

+ MethodRecognizer::kObjectIdentical))) {

EmitOptimizedStaticCall(function, arguments_descriptor, argument_count,

deopt_id, token_pos, locs);

} else {

« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »