Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: tests/standalone/javascript_compatibility_errors_test.dart

Issue 312693008: Add javascript compatibility warnings for strings that are not identical, but (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | tests/standalone/javascript_compatibility_warnings_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/javascript_compatibility_errors_test.dart
===================================================================
--- tests/standalone/javascript_compatibility_errors_test.dart (revision 37011)
+++ tests/standalone/javascript_compatibility_errors_test.dart (working copy)
@@ -35,6 +35,11 @@
y.toString(); /// 26: ok
var z = y.toString(); /// 27: ok
+ var a = "yz";
+ var b = "xyz";
+ b = b.substring(1);
+ if (identical(a, b)) { } /// 28: ok
+
if (x > 10) {
// Optimized code.
x is double; /// 30: ok
@@ -54,6 +59,11 @@
var z = "$y"; /// 45: ok
y.toString(); /// 46: ok
var z = y.toString(); /// 47: ok
+
+ var a = "yz";
+ var b = "xyz";
+ b = b.substring(1);
+ if (identical(a, b)) { } /// 48: ok
}
}
« no previous file with comments | « runtime/vm/parser.cc ('k') | tests/standalone/javascript_compatibility_warnings_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698