Issue 269343010: Adds single-precision and SIMD load/store to arm64.

Issue 269343010: Adds single-precision and SIMD load/store to arm64. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds single-precision and SIMD load/store to arm64. Also adds conversion between double an single-precision floats. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35933

Patch Set 5 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+763 lines, -423 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_arm64.h	View	1 2 3 4	5 chunks	+78 lines, -21 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1 2 3 4	7 chunks	+93 lines, -30 lines	0 comments	Download
M	runtime/vm/assembler_arm64_test.cc	View	1 2 3 4	2 chunks	+40 lines, -1 line	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1 2 3 4	5 chunks	+29 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View	1 2 3 4	4 chunks	+43 lines, -15 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1 2 3 4	28 chunks	+59 lines, -57 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2 3 4	48 chunks	+168 lines, -107 lines	0 comments	Download
M	runtime/vm/simulator_arm64.h	View	1 2 3 4	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2 3 4	7 chunks	+83 lines, -22 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 2 3 4	62 chunks	+161 lines, -159 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2 3 4	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3 4	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/269343010/diff/40001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/269343010/diff/40001/runtime/vm/assembler_arm64.cc#newcode704 runtime/vm/assembler_arm64.cc:704: // Since offset is 32-bits, it won't be ...

6 years, 7 months ago (2014-05-08 17:10:05 UTC) #2

zra

Thanks! https://codereview.chromium.org/269343010/diff/40001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/269343010/diff/40001/runtime/vm/assembler_arm64.cc#newcode704 runtime/vm/assembler_arm64.cc:704: // Since offset is 32-bits, it won't be ...

6 years, 7 months ago (2014-05-08 18:55:07 UTC) #3

zra

6 years, 7 months ago (2014-05-08 19:06:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r35933 (presubmit successful).

Expand Messages | Collapse Messages