Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25785003: "Reverting 28184" (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

"Reverting 28184" TBR=blois BUG= Committed: https://code.google.com/p/dart/source/detail?r=28186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+768 lines, -759 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 12 chunks +264 lines, -39 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 15 chunks +264 lines, -39 lines 0 comments Download
M sdk/lib/html/html_common/html_common.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + sdk/lib/html/html_common/jenkins_smi_hash.dart View 2 chunks +4 lines, -3 lines 0 comments Download
D sdk/lib/math/jenkins_smi_hash.dart View 1 chunk +0 lines, -41 lines 0 comments Download
M sdk/lib/math/math.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/math/math_sources.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D sdk/lib/math/point.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D sdk/lib/math/rectangle.dart View 1 chunk +0 lines, -169 lines 0 comments Download
M tests/html/canvasrenderingcontext2d_test.dart View 7 chunks +11 lines, -11 lines 0 comments Download
M tests/html/client_rect_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/html/point_test.dart View 3 chunks +10 lines, -7 lines 0 comments Download
A + tests/html/rect_test.dart View 6 chunks +53 lines, -51 lines 0 comments Download
M tests/html/svgelement_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D tests/lib/math/point_test.dart View 1 chunk +0 lines, -122 lines 0 comments Download
D tests/lib/math/rectangle_test.dart View 1 chunk +0 lines, -157 lines 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/dom/src/CssRectangle.dart View 1 chunk +3 lines, -4 lines 0 comments Download
A tools/dom/src/Point.dart View 1 chunk +72 lines, -0 lines 0 comments Download
A + tools/dom/src/Rectangle.dart View 2 chunks +61 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 2 chunks +7 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ClientRect.darttemplate View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Screen.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
the analyzer caught some issues. reverting to fix.
7 years, 2 months ago (2013-10-02 22:13:05 UTC) #1
Emily Fortuna
Committed patchset #1 manually as r28186 (presubmit successful).
7 years, 2 months ago (2013-10-02 22:13:31 UTC) #2
blois
7 years, 2 months ago (2013-10-02 22:28:07 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698