tools/dom/scripts/generator.py - Issue 25785003: "Reverting 28184"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/generator.py

Issue 25785003: "Reverting 28184" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/generator.py

diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py

index 8243241e99f60e6f0cdf47fba2b60b973c6ec8de..ef81ebd8d872d06b7b127e9c5a673ec37e4eab37 100644

--- a/tools/dom/scripts/generator.py

+++ b/tools/dom/scripts/generator.py

@@ -1064,7 +1064,7 @@ _idl_type_registry = monitored.Dict('generator._idl_type_registry', {

'Array': TypeData(clazz='Primitive', dart_type='List'),

'custom': TypeData(clazz='Primitive', dart_type='dynamic'),

'ClientRect': TypeData(clazz='Interface',

- dart_type='Rectangle', suppress_interface=True),

+ dart_type='Rect', suppress_interface=True),

'Date': TypeData(clazz='Primitive', dart_type='DateTime', native_type='double'),

'DOMObject': TypeData(clazz='Primitive', dart_type='Object', native_type='ScriptValue'),

'DOMString': TypeData(clazz='Primitive', dart_type='String', native_type='String'),

@@ -1099,8 +1099,7 @@ _idl_type_registry = monitored.Dict('generator._idl_type_registry', {

'SVGElement': TypeData(clazz='Interface', custom_to_dart=True),

'ClientRectList': TypeData(clazz='Interface',

- item_type='ClientRect', dart_type='List<Rectangle>',

- suppress_interface=True),

+ item_type='ClientRect', dart_type='List<Rect>', suppress_interface=True),

'CSSRuleList': TypeData(clazz='Interface',

item_type='CSSRule', suppress_interface=True),

'CSSValueList': TypeData(clazz='Interface',

« no previous file with comments | « tests/lib/math/rectangle_test.dart ('k') | tools/dom/src/CssRectangle.dart » ('j') | no next file with comments »