Avoid generating VariableUse nodes with non-identifier names

Avoid generating VariableUse nodes with non-identifier names

The change uses of VariableUse where the the 'name' is a JavaScript expression.  This is very naughty, since the minifier can't tell which names are free in a function.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35508

[sra1, 2014-04-26 17:32:15]

Judging by the first diff in ssa/codegen.dart, you agree with this change :-)

Ultimately, namer.isolateAccess must be removed, since it is the old pattern of
generating code by strings.  I will attack the TODOs later.

[floitsch, 2014-04-28 14:17:50]

LGTM.

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right):

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:706: static RegExp
_identiferOrOperatorRE =
identifierOrOperatorRE  (missing "i")

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:707: new
RegExp(r'^([A-Za-z_$][A-Za-z_$0-9]*|[-<=>+\*\/%^!|&~,]*)$');
you don't need to escape '*' inside a character group. nor "/".

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart
(right):

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart:312:
r'(function(){ var True = true; #; })();', [statements]),
Nit: I would prefer if this change was done in a separate CL.

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2042: js.Expression
lazyGetter = backend.namer.isolateLazyInitializerAccess(element);
long line.

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2043:
//js.VariableUse target = new js.VariableUse(lazyGetter);
dead code.

[sra1, 2014-04-28 23:00:41]

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right):

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:706: static RegExp
_identiferOrOperatorRE =
On 2014/04/28 14:17:51, floitsch wrote:
> identifierOrOperatorRE  (missing "i")

Done.

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:707: new
RegExp(r'^([A-Za-z_$][A-Za-z_$0-9]*|[-<=>+\*\/%^!|&~,]*)$');
On 2014/04/28 14:17:51, floitsch wrote:
> you don't need to escape '*' inside a character group. nor "/".

'Done'.  After the operators cl, the test is just for an identifier.

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart
(right):

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart:312:
r'(function(){ var True = true; #; })();', [statements]),
On 2014/04/28 14:17:51, floitsch wrote:
> Nit: I would prefer if this change was done in a separate CL.

Done.

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2042: js.Expression
lazyGetter = backend.namer.isolateLazyInitializerAccess(element);
On 2014/04/28 14:17:51, floitsch wrote:
> long line.

Done.

https://chromiumcodereview.appspot.com/255843005/diff/80001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:2043:
//js.VariableUse target = new js.VariableUse(lazyGetter);
On 2014/04/28 14:17:51, floitsch wrote:
> dead code.

Done.

[sra1, 2014-04-28 23:30:37]

Committed patchset #2 manually as r35508 (presubmit successful).