sdk/lib/_internal/compiler/implementation/js_backend/backend.dart - Issue 255843005: Avoid generating VariableUse nodes with non-identifier names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 255843005: Avoid generating VariableUse nodes with non-identifier names (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js/nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

index bbf2b4279ce815c0c68714db7041f57427d74303..0942a3ab39f713f6de3d14e9c6c1f65693b2c9ec 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

@@ -1771,13 +1771,12 @@ class JavaScriptBackend extends Backend {

// helper rather than reading it inside the helper to increase the

// chance of making the dispatch record access monomorphic.

jsAst.PropertyAccess record = new jsAst.PropertyAccess(

- use2, new jsAst.VariableUse(dispatchPropertyName));

+ use2, js(dispatchPropertyName));

List<jsAst.Expression> arguments = <jsAst.Expression>[use1, record];

- FunctionElement helper =

- compiler.findHelper('isJsIndexable');

- String helperName = namer.isolateAccess(helper);

- return new jsAst.Call(new jsAst.VariableUse(helperName), arguments);

+ FunctionElement helper = compiler.findHelper('isJsIndexable');

+ jsAst.Expression helperExpression = namer.elementAccess(helper);

+ return new jsAst.Call(helperExpression, arguments);

}

bool isTypedArray(TypeMask mask) {