Avoid generating VariableUse nodes with non-identifier names

sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * Assigns JavaScript identifiers to Dart variables, class-names and members.
  */
 class Namer implements ClosureNamer {
@@ skipping 877 matching lines @@
 
   String getStaticClosureName(Element element) {
     assert(Elements.isStaticOrTopLevelFunction(element));
     return getMappedGlobalName("${getNameX(element)}\$closure");
   }
 
   String isolateAccess(Element element) {
     return "${globalObjectFor(element)}.${getNameX(element)}";
   }
 
-  String isolateLazyInitializerAccess(Element element) {
-    return "${globalObjectFor(element)}.${getLazyInitializerName(element)}";
+  jsAst.Expression isolateLazyInitializerAccess(Element element) {
+    return js('#.#',
+        [globalObjectFor(element), getLazyInitializerName(element)]);
   }
 
-  String isolateStaticClosureAccess(Element element) {
-    return "${globalObjectFor(element)}.${getStaticClosureName(element)}()";
+  jsAst.Expression isolateStaticClosureAccess(Element element) {
+    return js('#.#()',
+        [globalObjectFor(element), getStaticClosureName(element)]);
+  }
+
+  // This name is used as part of the name of a TypeConstant
+  String uniqueNameForTypeConstantElement(Element element) {
+    // TODO(sra): If we replace the period with an identifier character,
+    // TypeConstants will have better names in unminified code.
+    return "${globalObjectFor(element)}.${getNameX(element)}";
   }
 
   String globalObjectForConstant(Constant constant) => 'C';
 
   String operatorIsPrefix() => r'$is';
 
   String operatorAsPrefix() => r'$as';
 
   String operatorSignature() => r'$signature';
 
@@ skipping 257 matching lines @@
     for (int i = 0; i < constant.fields.length; i++) {
       _visit(constant.fields[i]);
       if (failed) return;
     }
   }
 
   visitType(TypeConstant constant) {
     addRoot('Type');
     DartType type = constant.representedType;
     JavaScriptBackend backend = compiler.backend;
-    String name = backend.rti.getRawTypeRepresentation(type);
+    String name = backend.rti.getTypeRepresentationForTypeConstant(type);
     addIdentifier(name);
   }
 
   visitInterceptor(InterceptorConstant constant) {
     addRoot(constant.dispatchedType.element.name);
     add('methods');
   }
 
   visitDummy(DummyConstant constant) {
     add('dummy_receiver');
@@ skipping 59 matching lines @@
     int hash = _hashString(3, constant.type.element.name);
     for (int i = 0; i < constant.fields.length; i++) {
       hash = _combine(hash, _visit(constant.fields[i]));
     }
     return hash;
   }
 
   int visitType(TypeConstant constant) {
     DartType type = constant.representedType;
     JavaScriptBackend backend = compiler.backend;
-    String name = backend.rti.getRawTypeRepresentation(type);
+    String name = backend.rti.getTypeRepresentationForTypeConstant(type);
     return _hashString(4, name);
   }
 
   visitInterceptor(InterceptorConstant constant) {
     String typeName = constant.dispatchedType.element.name;
     return _hashString(5, typeName);
   }
 
   visitDummy(DummyConstant constant) {
     compiler.internalError(NO_LOCATION_SPANNABLE,
@@ skipping 124 matching lines @@
         if (!first) {
           sb.write('_');
         }
         sb.write('_');
         visit(link.head);
         first = true;
       }
     }
   }
 }