Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/js_backend/checked_mode_helpers.dart

Issue 255843005: Avoid generating VariableUse nodes with non-identifier names (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend; 5 part of js_backend;
6 6
7 class CheckedModeHelper { 7 class CheckedModeHelper {
8 final String name; 8 final String name;
9 9
10 const CheckedModeHelper(String this.name); 10 const CheckedModeHelper(String this.name);
11 11
12 Element getElement(Compiler compiler) => compiler.findHelper(name); 12 Element getElement(Compiler compiler) => compiler.findHelper(name);
13 13
14 jsAst.Expression generateCall(SsaCodeGenerator codegen, 14 jsAst.Expression generateCall(SsaCodeGenerator codegen,
15 HTypeConversion node) { 15 HTypeConversion node) {
16 Element helperElement = getElement(codegen.compiler); 16 Element helperElement = getElement(codegen.compiler);
17 codegen.world.registerStaticUse(helperElement); 17 codegen.world.registerStaticUse(helperElement);
18 List<jsAst.Expression> arguments = <jsAst.Expression>[]; 18 List<jsAst.Expression> arguments = <jsAst.Expression>[];
19 codegen.use(node.checkedInput); 19 codegen.use(node.checkedInput);
20 arguments.add(codegen.pop()); 20 arguments.add(codegen.pop());
21 generateAdditionalArguments(codegen, node, arguments); 21 generateAdditionalArguments(codegen, node, arguments);
22 String helperName = codegen.backend.namer.isolateAccess(helperElement); 22 jsAst.Expression helper = codegen.backend.namer.elementAccess(helperElement) ;
23 return new jsAst.Call(new jsAst.VariableUse(helperName), arguments); 23 return new jsAst.Call(helper, arguments);
24 } 24 }
25 25
26 void generateAdditionalArguments(SsaCodeGenerator codegen, 26 void generateAdditionalArguments(SsaCodeGenerator codegen,
27 HTypeConversion node, 27 HTypeConversion node,
28 List<jsAst.Expression> arguments) { 28 List<jsAst.Expression> arguments) {
29 // No additional arguments needed. 29 // No additional arguments needed.
30 } 30 }
31 31
32 static const List<CheckedModeHelper> helpers = const <CheckedModeHelper> [ 32 static const List<CheckedModeHelper> helpers = const <CheckedModeHelper> [
33 const MalformedCheckedModeHelper('checkMalformedType'), 33 const MalformedCheckedModeHelper('checkMalformedType'),
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 DartType type = node.typeExpression; 110 DartType type = node.typeExpression;
111 Element element = type.element; 111 Element element = type.element;
112 String isField = codegen.backend.namer.operatorIs(element); 112 String isField = codegen.backend.namer.operatorIs(element);
113 arguments.add(js.string(isField)); 113 arguments.add(js.string(isField));
114 codegen.use(node.typeRepresentation); 114 codegen.use(node.typeRepresentation);
115 arguments.add(codegen.pop()); 115 arguments.add(codegen.pop());
116 String asField = codegen.backend.namer.substitutionName(element); 116 String asField = codegen.backend.namer.substitutionName(element);
117 arguments.add(js.string(asField)); 117 arguments.add(js.string(asField));
118 } 118 }
119 } 119 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698