Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 25509003: It is statically OK to call methods on bottom type. (Closed)

Created:
7 years, 2 months ago by scheglov
Modified:
7 years, 2 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

It is statically OK to call methods on bottom type. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -34 lines) Patch
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickAssistProcessorImpl.java View 2 chunks +1 line, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java View 4 chunks +5 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java View 2 chunks +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/BottomTypeImpl.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 3 chunks +2 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/type/Type.java View 1 chunk +7 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/context/AnalysisContextFactory.java View 1 chunk +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 3 chunks +3 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 2 chunks +20 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/SimpleResolverTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/TypePropagationTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 2 months ago (2013-10-01 18:24:56 UTC) #1
jwren
On 2013/10/01 18:24:56, scheglov wrote: LGTM
7 years, 2 months ago (2013-10-01 18:32:49 UTC) #2
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-10-01 18:37:18 UTC) #3
scheglov
7 years, 2 months ago (2013-10-01 19:24:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698